[api-minor] Add "contentLength" to the information returned by the getMetadata method
#12642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/5af3c78a0e5e0d9/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b5cea25373b65e7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/b5cea25373b65e7/output.txt Total script time: 3.75 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/5af3c78a0e5e0d9/output.txt Total script time: 4.90 mins
|
…etMetadata` method Given that we already include the "Content-Disposition"-header filename, when it exists, it shouldn't hurt to also include the information from the "Content-Length"-header. For PDF documents opened via a URL, which should be a very common way for the PDF.js library to be used, this will[1] thus provide a way of getting the PDF filesize without having to wait for the `getDownloadInfo`-promise to resolve[2]. With these API improvements, we can also simplify the filesize handling in the `PDFDocumentProperties` class. --- [1] Assuming that the server is correctly configured, of course. [2] Since that's not *guaranteed* to happen in general, with e.g. `disableAutoFetch = true` set.
Snuffleupagus
force-pushed
the
api-getMetadata-contentLength
branch
from
a983061 to
01d12b4
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1490a8901c487df/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1490a8901c487df/output.txt Total script time: 4.24 mins Published |
timvandermeij
approved these changes
Nov 20, 2020
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we already include the "Content-Disposition"-header filename, when it exists, it shouldn't hurt to also include the information from the "Content-Length"-header.
For PDF documents opened via a URL, which should be a very common way for the PDF.js library to be used, this will[1] thus provide a way of getting the PDF filesize without having to wait for the
getDownloadInfo-promise to resolve[2].With these API improvements, we can also simplify the filesize handling in the
PDFDocumentPropertiesclass.Smaller/simpler diff with https://github.com/mozilla/pdf.js/pull/12642/files?w=1
[1] Assuming that the server is correctly configured, of course.
[2] Since that's not guaranteed to happen in general, with e.g.
disableAutoFetch = trueset.